mirror of https://github.com/go-gitea/gitea.git
Fix 500 on PR files API (#21602)
Fixes an 500 error/panic if using the changed PR files API with pages that should return empty lists because there are no items anymore. `start-end` is then < 0 which ends in panic. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>pull/21612/head
parent
ed47d0062e
commit
8430f738e2
|
@ -1443,7 +1443,11 @@ func GetPullRequestFiles(ctx *context.APIContext) {
|
||||||
end = totalNumberOfFiles
|
end = totalNumberOfFiles
|
||||||
}
|
}
|
||||||
|
|
||||||
apiFiles := make([]*api.ChangedFile, 0, end-start)
|
lenFiles := end - start
|
||||||
|
if lenFiles < 0 {
|
||||||
|
lenFiles = 0
|
||||||
|
}
|
||||||
|
apiFiles := make([]*api.ChangedFile, 0, lenFiles)
|
||||||
for i := start; i < end; i++ {
|
for i := start; i < end; i++ {
|
||||||
apiFiles = append(apiFiles, convert.ToChangedFile(diff.Files[i], pr.HeadRepo, endCommitID))
|
apiFiles = append(apiFiles, convert.ToChangedFile(diff.Files[i], pr.HeadRepo, endCommitID))
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue