mirror of https://github.com/mastodon/mastodon.git
![]() * Fix error responses in `from` search prefix (addresses mastodon/mastodon#17941) Using unsupported prefixes now reports a 422; searching for posts from an account the instance is not aware of reports a 404. TODO: The UI for this on the front end is abysmal. Searching `from:username@domain` now succeeds when `domain` is the local domain; searching `from:@username(@domain)?` now works as expected. * Remove unused methods on new Error classes as they are not being used Currently when `raise`d there are error messages being supplied, but this is not actually being used. The associated `raise`s have been edited accordingly. * Remove needless comments * Satisfy rubocop * Try fixing tests being unable to find AccountFindingConcern methods * Satisfy rubocop * Simplify `from` prefix logic This incorporates @ClearlyClaire's suggestion (see https://github.com/mastodon/mastodon/pull/17963#pullrequestreview-933986737). Accepctable account strings in `from:` clauses are more lenient than before this commit; for example, `from:@user@example.org@asnteo +cat` will not error, and return posts by @user@example.org containing the word "cat". This is more consistent with how Mastodon matches mentions in statuses. In addition, `from` clauses will not be checked for syntatically invalid usernames or domain names, simply 404ing when `Account.find_remote!` raises ActiveRecord::NotFound. New code for this PR that is no longer used has been removed. |
||
---|---|---|
.. | ||
activitypub | ||
admin | ||
connection_pool | ||
nodeinfo | ||
ostatus | ||
rss | ||
settings | ||
access_token_extension.rb | ||
account_reach_finder.rb | ||
activity_tracker.rb | ||
application_extension.rb | ||
cache_buster.rb | ||
delivery_failure_tracker.rb | ||
emoji_formatter.rb | ||
entity_cache.rb | ||
extractor.rb | ||
fast_geometry_parser.rb | ||
fast_ip_map.rb | ||
feed_manager.rb | ||
hash_object.rb | ||
html_aware_formatter.rb | ||
inline_renderer.rb | ||
link_details_extractor.rb | ||
permalink_redirector.rb | ||
plain_text_formatter.rb | ||
potential_friendship_tracker.rb | ||
rate_limiter.rb | ||
request.rb | ||
request_pool.rb | ||
response_with_limit.rb | ||
rss_builder.rb | ||
scope_parser.rb | ||
scope_transformer.rb | ||
search_query_parser.rb | ||
search_query_transformer.rb | ||
status_filter.rb | ||
status_finder.rb | ||
status_reach_finder.rb | ||
suspicious_sign_in_detector.rb | ||
tag_manager.rb | ||
text_formatter.rb | ||
themes.rb | ||
toc_generator.rb | ||
user_settings_decorator.rb | ||
validation_error_formatter.rb | ||
video_metadata_extractor.rb | ||
webfinger.rb | ||
webfinger_resource.rb |